Comments

1. Kris says:

   This is interesting. Will it work though if you have several kinds of product pages, each using a different set of modules?

   May 21, 2020 at 6:04 pm • Reply •

2. PAJ says:

   It should work as any scripts that do not get detected by Magepack and bundled will still be loaded by Magento via the usual require process. You would need to identify these and manually add them to the bundle configuration for product pages.

   May 25, 2020 at 4:41 pm • Reply •

3. Rafael Corrêa Gomes says:

   Wow, this is a very good method to bundling, it seems a smooth integration, thank you for sharing it!

   May 29, 2020 at 9:58 pm • Reply •

4. mage2fanny says:

   Just a note about patching for MagePack Magento 2 Module, it has been merged into Magento 2.4
   So no manual patching required if you’re now on Magento 2.4!

   August 13, 2020 at 2:21 am • Reply •

   • PAJ says:

     Thanks for this, I have updated the post.

     August 13, 2020 at 11:06 am • Reply •

5. Peter Kincses says:

   Thank you for the post, I found it quite useful! Is there an option to bundle js form multiple stores which run from the same codebase with different urls? ie, x.com, y.com, z.com? We currently run 25 stores from the same codebase, not just different locale’s but different themes and not every store has the same modules enabled, hence js output can also be different.
   I’ve noticed that only one file is generated so if I run magepack generate for x.com and then magepack generate for y.com, y.com will overwrite x.com’s magepack.config.js.

   September 22, 2020 at 6:13 pm • Reply •

   • PAJ says:

     I think this issue has been raised by others on github. I have used the module with a multi store Magento 2 but the stores were using the same parent theme so there were no major js differences between the themes. I guess what I would do would be to create a magepack config for each store naming them store1, store2 etc. then rename them to the magepack.config.js and deploy for each store theme. It’s a bit clunky but should work…

     September 23, 2020 at 5:04 pm • Reply •

6. Vivek Shingala says:

   Hi

   Thank you for this wonderful post.

   I have a question.

   Top Tip – if for any reason you want to generate the magepack.config.js bundle config again remember to disable the Magepack module first!

   Instead of disabling module, can we remove magepack.config.js file for creating the new one?

   September 29, 2020 at 4:09 pm • Reply •

   • PAJ says:

     If you try to create the config file whilst magepack is enabled it will parse the bundles JS in the page and not the required js.

     October 21, 2020 at 9:32 am • Reply •

7. Nicolas says:

   This may be a silly question but do I run: npm install -g magepack –unsafe-perm=true –allow-root from the Magento directory (public_html) or from /srv/ folder? My host does not provide root access.

   October 21, 2020 at 5:48 am • Reply •

   • PAJ says:

     It doesn’t matter where you run npm install – the install environment is saved in the home directory of the user.

     October 21, 2020 at 9:32 am • Reply •

8. Megha says:

   Hi,

   Thank you for the post, it’s very useful.

   I’ve one question that it’s hard to apply it to a Magento Cloud instance as we can’t run npm command directly via SSH access following their document

   Is there a way to apply Magepack to a Magento Cloud instance?

   October 29, 2020 at 7:58 am • Reply •

9. Ankur says:

   Hi Paj

   Thank you for this wonderful post.

   I’ve one question.

   I’m using magepack on a Magento default instance on my local but It’s hard to apply it to a Magento Cloud instance as we can’t run npm command directly via SSH access following their document

   Is there a way to apply magepack to a Magento Cloud instance?

   Waiting for your response

   October 29, 2020 at 10:27 pm • Reply •

   • PAJ says:

     Sorry, but I have no experience with Magento cloud…

     November 3, 2020 at 8:21 pm • Reply •

   • Solteq says:

     you need to have magepack.config in repo, at this part to magento.app.yaml

     echo “\n================================== Install and configure Magepack – Start ===============================”
     unset NPM_CONFIG_PREFIX
     curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.35.1/install.sh | bash
     export NVM_DIR=”$HOME/.nvm”
     [ -s “$NVM_DIR/nvm.sh” ] && \. “$NVM_DIR/nvm.sh”
     nvm install –lts=dubnium
     npm install -g magepack
     echo “\n================================== create bundle ===============================”
     magepack bundle
     echo “\n================================== Install and configure Magepack – END =================================”

     so it will install magepack and run bundle command in cloud

     November 13, 2020 at 12:36 pm • Reply •

     • Haritha says:

       Hi Solteq,

       While trying to implement in the build phase of .magento.app.yaml, it results in issue below as the static content deployment is running after the build phase. Is there fix for this?
       —————————————————————————————————————-
       W: ERROR No locales found! Make sure magepack is running after static content is deployed.
       —————————————————————————————————————-

       June 23, 2021 at 8:57 am •

10. Fabio says:

    during generation i constantly get the following message

    can you help me?

    waitFor is deprecated and will be removed in a future release. See https://github.com/puppeteer/puppeteer/issues/6214 for details and how to migrate your code.
    ✔ Finished collecting modules for bundle “product”. 17:27:11
    ℹ Collecting modules for bundle “checkout”. 17:27:11
    waitFor is deprecated and will be removed in a future release. See https://githu b.com/puppeteer/puppeteer/issues/6214 for details and how to migrate your code.

    November 3, 2020 at 5:46 pm • Reply •

    • PAJ says:

      Apart from the info in the error message I can’t help you with this one. What OS are you installing on? Are all your dependancies up to date?

      November 3, 2020 at 8:20 pm • Reply •

11. Ank says:

    Hi Paj,

    We’ve done enabled the magepack bundling as well as minify js also enabled but at that time this bundle common or cms also need to be minify but it didn’t hence it is giving an error of 404 for bundle-common.min.js file so do you have an idea how to fix this one..and when i disable minify js then the bundle-common.js and other files are generated but didn’t reduce the number of files..its same after or before magepack bundling..do we need to make any extra setting for this.

    November 11, 2020 at 2:07 pm • Reply •

12. Brandon Irwin says:

    Just an update to your docs about Magento Cloud, it would be && and not &&
    In case someone doesn’t go and read the comment with the code.

    But great doc super helpful!!

    November 25, 2020 at 10:20 pm • Reply •

    • PAJ says:

      &&
      or
      &&
      ?

      January 6, 2021 at 12:57 pm • Reply •

      • boldhedgehog says:

        In the script for Magento Cloud the ampersand symbol “&” is displayed as escaped entity “& amp;”

        January 14, 2021 at 2:14 pm •

      • PAJ says:

        ok – now I understand – WordPress does that a lot it’s very annoying…

        January 15, 2021 at 6:38 pm •

13. Amit Saini says:

    I Paj,
    I have multi website magento 2.3.3 store. I want to create each website has separated js bundle not all for all websites. Can you please tell me, with magepack bundling, this is possible or not?

    December 7, 2020 at 1:53 pm • Reply •

14. Lopez says:

    My host provider does not allow installing Chromium and they recommend to “generate the bundles locally”. Is there some kind of tutorial to do this? Do you know a hosting provided that allows the installation of the required dependencies?
    Thank you for the information!

    January 5, 2021 at 8:40 pm • Reply •

    • PAJ says:

      I think if you are a developer and you don’t have full control over your production server then maybe you need to look at new hosting…

      I would also recommend virtual servers, i.e. if you are using Mac or Windows install a VMWare linux server and you can install the dependencies you require and generate the bundles locally. Better still create a docker container to do it.

      Perhaps it would be useful to have an online service for creating Magepack bundles for you?

      January 6, 2021 at 12:56 pm • Reply •

15. shiloh says:

    Hello! Thank you so much for such a great article.

    I am wondering if you have any experience with megapack being used where there is a custom checkout such as the Amasty one step checkout. Megapack does not seem to work so well with 3df party checkout modules and it essentially breaks the checkout with the page never loading. It works perfect on every site I have that is using the native Magento checkout.

    Seems like there is something I am missing, Is there a way to exclude checkout from the bundling or give some additional direction to accommodate the 3rd party checkout module?

    Thanks again!

    January 15, 2021 at 4:01 pm • Reply •

    • PAJ says:

      There is a real easy solution to this – just disable the bundling for checkout pages… if you look at the isEnabled method in the Block\BundlesLoader class this determines whether the module is enabled and bundling is applied. Simply detect the checkout page here and return false to disable bundling at checkout…

      January 15, 2021 at 6:40 pm • Reply •

      • Cristian says:

        I need to disable checkout and put my isEnabled like this:
        public function isEnabled()
        {
        return $this->scopeConfig->isSetFlag(
        self::XML_PATH_ENABLE_MAGEPACK_BUNDLING,
        ScopeInterface::SCOPE_STORE
        );
        if ($this->request->getFullActionName() == ‘checkout_index_index){

        // disable for checkout
        return false;
        }
        }
        But, the checkout continues to be optimized

        March 15, 2021 at 9:03 pm •

      • PAJ says:

        You are returning true with if self::XML_PATH_ENABLE_MAGEPACK_BUNDLING before the checkout logic can function. The checkout logic must occur before the module enabled check.

        March 16, 2021 at 9:12 am •

16. Brandon Irwin says:

    You mentioned you were in docker running magepack on your php container.

    I have followed the docs using the php docker container but when i run magepack generate –debug it gives me a failed to launch the browser process.

    Have you ran into this?

    March 8, 2021 at 7:03 pm • Reply •

17. Janko Hrasko says:

    Collecting modules for bundle “category”. 08:54:43

    ERROR waiting for function failed: timeout 30000ms exceeded 08:55:14

    at new WaitTask (/usr/lib/node_modules/magepack/node_modules/puppeteer/lib/DOMWorld.js:549:28)
    at DOMWorld.waitForFunction (/usr/lib/node_modules/magepack/node_modules/puppeteer/lib/DOMWorld.js:454:12)
    at Frame.waitForFunction (/usr/lib/node_modules/magepack/node_modules/puppeteer/lib/FrameManager.js:657:28)
    at Page.waitForFunction (/usr/lib/node_modules/magepack/node_modules/puppeteer/lib/Page.js:1141:29)
    at module.exports (/usr/lib/node_modules/magepack/lib/generate/collectModules.js:12:16)
    at Object.category (/usr/lib/node_modules/magepack/lib/generate/collector/category.js:40:39)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async module.exports (/usr/lib/node_modules/magepack/lib/generate.js:24:13)

    Where can I set timeout?

    July 9, 2021 at 11:01 am • Reply •

18. Janko Hrasko says:

    Or whats the problem? I found this :

    // Since page navigation requires us to re-install the pageScript, we should track
    // timeout on our end.
    if (timeout) {
    const timeoutError = new TimeoutError(`waiting for ${title} failed: timeout ${timeout}ms exceeded`);
    this._timeoutTimer = setTimeout(() => this.terminate(timeoutError), timeout);
    }
    this.rerun();

    July 9, 2021 at 11:08 am • Reply •

19. Janko Hrasko says:

    Collecting modules for bundle “category”. 09:06:47

    ERROR waiting for function failed: timeout 60000ms exceeded 09:07:48

    at new WaitTask (/usr/lib/node_modules/magepack/node_modules/puppeteer/lib/DOMWorld.js:549:28)
    at DOMWorld.waitForFunction (/usr/lib/node_modules/magepack/node_modules/puppeteer/lib/DOMWorld.js:454:12)
    at Frame.waitForFunction (/usr/lib/node_modules/magepack/node_modules/puppeteer/lib/FrameManager.js:657:28)
    at Page.waitForFunction (/usr/lib/node_modules/magepack/node_modules/puppeteer/lib/Page.js:1141:29)
    at module.exports (/usr/lib/node_modules/magepack/lib/generate/collectModules.js:12:16)
    at Object.category (/usr/lib/node_modules/magepack/lib/generate/collector/category.js:40:39)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async module.exports (/usr/lib/node_modules/magepack/lib/generate.js:24:13)

    I found this :
    // Since page navigation requires us to re-install the pageScript, we should track
    // timeout on our end.
    if (timeout) {
    const timeoutError = new TimeoutError(`waiting for ${title} failed: timeout ${timeout}ms exceeded`);
    this._timeoutTimer = setTimeout(() => this.terminate(timeoutError), timeout);
    }
    this.rerun();

    Whats the problem?

    July 9, 2021 at 11:09 am • Reply •

20. helmi says:

    why Magepack does not bundle all JS ?
    I added some js to magepack.config.js file, but magepack doesn’t support these js when doing the bundling.
    can you help me?

    August 12, 2022 at 11:54 am • Reply •

21. Ram says:

    Try this with speed network

    December 15, 2022 at 11:02 am • Reply •

22. Ram says:

    mageback bundle -m command is only working if we run on command line, but if we try to run this command via Jenkins ansible script getting below error

    [Errno 2] No such file or directory

    Any idea on this?

    December 15, 2022 at 11:06 am • Reply •

This site uses Akismet to reduce spam. Learn how your comment data is processed.